Cleaning of duplicate attributes removed from UpdateMedia

[chriss]

In changeset 20523 (http://svn.linuxmce.org/trac.cgi/changeset/20523) cmiron removed the code to remove duplicate attributes from UpdateMedia.

Does anybody know why this happened? Any problems with the code? BTW, who is cmiron, maybe a pluto guy?

I started looking at the code because UpdateMedia is occasionally putting duplicated attributes into my database.

thanks
/chriss

[Marie.O]

chriss,

this is done in trunk.

We are working in the branch 0810.

rgds
Oliver

[chriss]

yeah, sure. But it has been done quite some time ago and therefore was copied to the 0810 branch... it found that particular changeset when following the history of the current branch.

[Marie.O]

I stand corrected.

Yes, cmiron used to be part of the Pluto dev team, afaict.

Feel free to check the code, and do the necessary changes. Just make sure, they work, before commiting, and feeling the wrath of Zaerc for breaking the built.

rgds
Oliver

[Zaerc]

Must have been some reason for the change.  But it might be worth a try to enable it again and test.  Maybe the old mantis tracking system had some info on it but I don't think it was resurected when our servers moved away from pluto unfortunately. 

Anyway, thanks a bunch for all the work you have been putting in fixing things, much appreciated.  And you can ignore that "wrath of Zaerc" remark (well at least until we go beta ).

[Marie.O]

Zaerc is always the nice guy ... at first 

[hari]

mantis is still available. Contact me on #linuxmce-devel.

br Hari

[totallymaxed]

In changeset 20523 (http://svn.linuxmce.org/trac.cgi/changeset/20523) cmiron removed the code to remove duplicate attributes from UpdateMedia.

Does anybody know why this happened? Any problems with the code? BTW, who is cmiron, maybe a pluto guy?

I started looking at the code because UpdateMedia is occasionally putting duplicated attributes into my database.

thanks
/chriss

cmiron = Chris Miron (and yes he was a Pluto guy)

Andrew