LinuxMCE Forums

General => Developers => Topic started by: mkbrown69 on January 09, 2014, 04:10:59 am

Title: DNS inconsistencies, input sought.
Post by: mkbrown69 on January 09, 2014, 04:10:59 am
Hi Folks!

Being a sysadmin type, I'm now trying to work my way through various sysadmin type Trac issues.  I just patched a NIS issue (Thanks Phenigma for committing it!), and now I'm currently working on a DNS related one.  I'm doing the relevant patches against 10.04, and will diff against 12.04 as well (I'm currently running 10.04, and plan to do an in-place upgrade).

http://svn.linuxmce.org/trac/ticket/1769

Some of this is easy to fix, but some needs some input.  Three scripts actually backup and manage aspects of resolv.conf on the core (trunk/src):
BootScripts/Network_DNS.sh
BootScripts/Network_Parameters.sh
BootScripts/Network_Setup.sh

Would it not be better/easier to maintain if only one script managed that resolv.conf file?  I may be missing out on why it is the way it is, so I thought I'd put it out there for those more knowledgable about LMCE internals to comment...

Thanks for your time!

/Mike
Title: Re: DNS inconsistencies, input sought.
Post by: tschak909 on January 09, 2014, 04:16:44 pm
Thanks so much, for working on this!

I would guess compartmentalization, but feel free to dig around to see where these scripts are called, and why. If it can be simplified, by all means, throw in a patch and we can test.

(The reason I put such emphasis on studying what is already there, is to understand the intended feature set, and to avoid regressions while simplifying or refactoring code.)

-Thom
Title: Re: DNS inconsistencies, input sought.
Post by: mkbrown69 on January 23, 2014, 05:19:29 am
Thom,

Will do.  I try to understand how things work and why, before I dive in (which means things take a while ;-). I'll look into the resolv.conf stuff shortly.  I've submitted patches for 12.04 (which I'm now running) against ticket 1769 which should fix the local DNS updates from dhcpd. 

HTH!

/Mike
Title: Re: DNS inconsistencies, input sought.
Post by: tschak909 on January 23, 2014, 05:31:05 am
Thanks,
-Thom
Title: Re:
Post by: phenigma on January 30, 2014, 09:43:07 pm
I'll have a look at getting these committed this weekend.  Thanks  mkbrown69!  J.

Sent from my SGH-I927 using Tapatalk