Author Topic: Cleaning of duplicate attributes removed from UpdateMedia  (Read 1639 times)

chriss

  • Veteran
  • ***
  • Posts: 140
    • View Profile
Cleaning of duplicate attributes removed from UpdateMedia
« on: January 13, 2009, 09:38:57 am »
In changeset 20523 (http://svn.linuxmce.org/trac.cgi/changeset/20523) cmiron removed the code to remove duplicate attributes from UpdateMedia.

Does anybody know why this happened? Any problems with the code? BTW, who is cmiron, maybe a pluto guy?

I started looking at the code because UpdateMedia is occasionally putting duplicated attributes into my database.

thanks
/chriss

posde

  • Administrator
  • LinuxMCE God
  • *****
  • Posts: 2988
  • Wastes Life On LinuxMCE Since 2007
    • View Profile
    • My Home
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #1 on: January 13, 2009, 10:29:25 am »
chriss,

this is done in trunk.

We are working in the branch 0810.

rgds
Oliver

chriss

  • Veteran
  • ***
  • Posts: 140
    • View Profile
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #2 on: January 13, 2009, 10:53:14 am »
yeah, sure. But it has been done quite some time ago and therefore was copied to the 0810 branch... it found that particular changeset when following the history of the current branch.

posde

  • Administrator
  • LinuxMCE God
  • *****
  • Posts: 2988
  • Wastes Life On LinuxMCE Since 2007
    • View Profile
    • My Home
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #3 on: January 13, 2009, 11:02:22 am »
I stand corrected.

Yes, cmiron used to be part of the Pluto dev team, afaict.

Feel free to check the code, and do the necessary changes. Just make sure, they work, before commiting, and feeling the wrath of Zaerc for breaking the built. :)

rgds
Oliver

Zaerc

  • Alumni
  • LinuxMCE God
  • *
  • Posts: 2256
  • Department of Redundancy Department.
    • View Profile
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #4 on: January 13, 2009, 11:06:52 am »
Must have been some reason for the change.  But it might be worth a try to enable it again and test.  Maybe the old mantis tracking system had some info on it but I don't think it was resurected when our servers moved away from pluto unfortunately. 

Anyway, thanks a bunch for all the work you have been putting in fixing things, much appreciated.  And you can ignore that "wrath of Zaerc" remark (well at least until we go beta ;)).
"Change is inevitable. Progress is optional."
-- Anonymous


posde

  • Administrator
  • LinuxMCE God
  • *****
  • Posts: 2988
  • Wastes Life On LinuxMCE Since 2007
    • View Profile
    • My Home
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #5 on: January 13, 2009, 11:09:43 am »
Zaerc is always the nice guy ... at first  ;D

hari

  • Administrator
  • LinuxMCE God
  • *****
  • Posts: 2421
    • View Profile
    • ago control
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #6 on: January 13, 2009, 02:52:21 pm »
mantis is still available. Contact me on #linuxmce-devel.

br Hari
rock your home - http://www.agocontrol.com home automation

totallymaxed

  • LinuxMCE God
  • ****
  • Posts: 4426
  • Smart Home Consulting
    • View Profile
    • Dianemo - at home with technology
Re: Cleaning of duplicate attributes removed from UpdateMedia
« Reply #7 on: January 13, 2009, 06:03:42 pm »
In changeset 20523 (http://svn.linuxmce.org/trac.cgi/changeset/20523) cmiron removed the code to remove duplicate attributes from UpdateMedia.

Does anybody know why this happened? Any problems with the code? BTW, who is cmiron, maybe a pluto guy?

I started looking at the code because UpdateMedia is occasionally putting duplicated attributes into my database.

thanks
/chriss

cmiron = Chris Miron (and yes he was a Pluto guy)

Andrew
« Last Edit: January 13, 2009, 06:45:17 pm by totallymaxed »
Andy Herron,
Convergent Home Technologies Ltd
United Kingdom

Read My Blog; http://ellipticalcurve.com

Contact me for Smart Home consulting advice here;
@herron on Twitter, totallymaxed+consulting@gmail.com via email or PM me here.

Get a Dianemo S License: http://forum.linuxmce.org/index.php?topic=8880.0
iOS Orbiter: http://wiki.linuxmce.org/index.php/Dianemo_iOS_Orbiter
Follow us on Facebook: https://www.facebook.com/pages/Dianemo-Home-Automation/226019387454465

Sales & Info:
http://www.dianemo.co.uk