Scroll bars in web-admin

[PeteK]

Hi gang--

I encountered a problem when trying to move a media file via web-admin.  When I select the 'Move file' button on the file's page (through Media Files Sync), It opens a new window to allow you to select a new destination.  Unfortunately, this window does not have scroll bars, and I can't see the items off the bottom of the page.  Is there a way to allow scrolling in this page?

The .php file is: charon-merge/web/pluto-admin/languages/en/moveFile.lang.php

Thanks,
-PeteK

[jondecker76]

I just took a peak. if you look at line 129 in charon-merge/web/pluto-admin/operations/mediaBrowser/editMediaFile.php you will see this window opened with

Code:

<input type="button" class="button" name="moveFile" value="Move file to other directory" onClick="windowOpen(\'index.php?section=moveFile&fileID='.$fileID.'&filePath='.urlencode(stripslashes($rowFile['Path']).'/'.$rowFile['Filename']).'\',\'width=500,height=400,toolbars=true,scrollbars=true,resizable=1\');">

so it appears to be opened with both scrollbars, and being resizable (though I'm not sure if the resizable=1 should be resizable=true. You may want to look at whether changing the "true" to 1, or vice-versa.

I couldn't reproduce because I don't have many storage devices...

[Zaerc]

I just took a peak. if you look at line 129 in charon-merge/web/pluto-admin/operations/mediaBrowser/editMediaFile.php you will see this window opened with

Code:

<input type="button" class="button" name="moveFile" value="Move file to other directory" onClick="windowOpen(\'index.php?section=moveFile&fileID='.$fileID.'&filePath='.urlencode(stripslashes($rowFile['Path']).'/'.$rowFile['Filename']).'\',\'width=500,height=400,toolbars=true,scrollbars=true,resizable=1\');">

so it appears to be opened with both scrollbars, and being resizable (though I'm not sure if the resizable=1 should be resizable=true. You may want to look at whether changing the "true" to 1, or vice-versa.

I couldn't reproduce because I don't have many storage devices...

I think you might be on to something there jondecker76, according to this page: http://www.w3schools.com/htmldom/met_win_open.asp the values for those should be set to "on", "off", "0" or "1" and no mention of "true".  So it could just be just another minor bug to fix.

[PeteK]

Thanks guys!  I can verify when I get home, if someone doesn't beat me to it.


-PeteK

[PeteK]

Setting

Code:

scrollbars=1

worked.

The other change that needs to be made is to replace

Code:

toolbars=true

with:

Code:

toolbar=1

(note that the correct parameter is 'toolbar,' not 'toolbars'

This was tested with firefox in linux.

I don't have CVS commit permissions, so if one of you could commit the changes, I'd definitely appreciate it.  Or I can bug DanielK for permissions.

Thanks a lot for the help, guys.

-PeteK

[PeteK]

Committed in revision 21416 on linuxmce.org