Author Topic: Tester for updateMedia id3 unicode fix needed  (Read 12616 times)

KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Tester for updateMedia id3 unicode fix needed
« on: May 27, 2010, 01:48:48 pm »
Hi everybody,

it seems as we have some problems reading id3 files with special characters. At the moment I try to change the underlaying tagging library to fix this, but I need some help testing the stuff. At this point I haven't added any new features, so testing would be limited to everything that is possible with the original version (like scanning, removing/editing of tags, etc.).

As this is an early version, you maybe shouldn't use it on your productive systems.

UpdateMedia.rar (784 KB)



An actual patch can be found here: http://svn.linuxmce.org/trac.cgi/ticket/698



Thanks for your help,
KingCrab
« Last Edit: June 04, 2010, 08:55:48 pm by KingCrab »

tschak909

  • LinuxMCE God
  • ****
  • Posts: 5549
  • DOES work for LinuxMCE.
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #1 on: May 27, 2010, 02:28:23 pm »
Hello, can you provide an svn diff to attach to a trac ticket, so we can track this?

-Thom

murcel

  • Guru
  • ****
  • Posts: 198
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #2 on: May 28, 2010, 11:54:34 pm »
so how can i help?

murcel


Hi everybody,

it seems as we have some problems reading id3 files with special characters. At the moment I try to change the underlaying tagging library to fix this, but I need some help testing the stuff. At this point I haven't added any new features, so testing would be limited to everything that is possible with the original version (like scanning, removing/editing of tags, etc.).

As this is an early version, you maybe shouldn't use it on your productive systems.

UpdateMedia.rar (784 KB)

Thanks for your help,
KingCrab

KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #3 on: May 30, 2010, 08:25:04 am »
@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.


murcel

  • Guru
  • ****
  • Posts: 198
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #4 on: May 30, 2010, 03:01:00 pm »
First tests are good.
German umlauts are imported correctly.

@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.



tschak909

  • LinuxMCE God
  • ****
  • Posts: 5549
  • DOES work for LinuxMCE.
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #5 on: May 30, 2010, 05:03:34 pm »
Dude, that's not the point, maybe we'd like to _HELP_.

I do not want "go off in a cave and do all the work yourself" to be the norm.

hmm.

-Thom

@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.



KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #6 on: June 05, 2010, 08:32:27 am »
New Version should fix some problems and add basic ape support.

UpdateMedia.zip (1.5 MB)

KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #7 on: June 15, 2010, 07:09:44 pm »
With a little luck everything is still working  ;) + ogg and flac fixed

UpdateMedia.gz (1.5 MB)

apagg

  • Veteran
  • ***
  • Posts: 60
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #8 on: June 15, 2010, 10:25:13 pm »
Great work

I have utf support for mp3 flac and ogg, but only picture for mp3.


apagg

  • Veteran
  • ***
  • Posts: 60
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #9 on: June 16, 2010, 09:45:40 pm »
Import of .mkv and .avi are broken in the last UpdateMedia :(

KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #10 on: June 17, 2010, 09:59:41 pm »
That's strange. Didn't know I touched the video part. Could you descripe what happens? Does it definitely happen with the last version for the first time?

apagg

  • Veteran
  • ***
  • Posts: 60
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #11 on: June 18, 2010, 08:35:09 pm »
I have done more testing it looks like it happens with earlier versions as well. The same result happens if the .mp3 file dont contain any tags.

Logfile from original UpadateMedia: http://pastebin.com/Liy8JTqh

Your latest: http://pastebin.com/MCLCfvfe

tschak909

  • LinuxMCE God
  • ****
  • Posts: 5549
  • DOES work for LinuxMCE.
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #12 on: June 18, 2010, 09:16:57 pm »
we REALLY need someone to OWN UpdateMedia.

-Thom

KingCrab

  • Regular Poster
  • **
  • Posts: 45
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #13 on: June 20, 2010, 07:46:34 pm »
Next one. Video and empty mp3 files shouldn't crash any more.

UpdateMedia.gz (1.5 MB)

apagg

  • Veteran
  • ***
  • Posts: 60
    • View Profile
Re: Tester for updateMedia id3 unicode fix needed
« Reply #14 on: June 20, 2010, 09:50:54 pm »
My testing so far

.mp3 (id3 v2.3):Works for special characters and pictures
.mp3 (id3 v2.4):Works for special characters and pictures
.ogg: works for special characters
.flac: works for special characters
.mkv: works for special characters in filename
.avi: works for special characters in filename

great work :)