LinuxMCE Forums
General => Users => Topic started by: jondecker76 on June 27, 2008, 11:27:28 am
-
I've spent the last several days fixing the bugs in the web admin playlist editor, and designed a new over/under layout that will make the playlist editor much more user-friendly. The code is fixed, and the layout design is done, but I am no artist. I'm looking for someone that can use my place-holder graphics as templates and make something that is a little more visually appealing.
Below is the layout rendered in firefox. Any volunteers?
(http://i229.photobucket.com/albums/ee95/jondecker76/playlist_admin.png)
-
Jon - on the testing side, could I get in on that at all? Would like to give you feed back on using it in practice... particularly when creating large playlists from large databases of music....
-
I'm glad to see something happening with the playlist editor, it really needs some help to become usable.
I would like to add some suggestions though for the design.
I think a lot of us have an incredible amount of media files to sort through
- Is this interface going to make use of id tags to categorize in folders? If so, how would those folders be traversed.
- Or instead would it just be hard drive folders as the organization structure.
The MD interface obviously makes use of some sorting by gene, group and such, but I'm not even sure if it allows the ability to create a play list there.
my $.02
-
thanks guys I will definitely like feedback and input. I will post back when things are integrated enough for testing purposes while I wait to see if anyone is interested in doing the graphic work.
Jimmy - It just uses database information, so you will be abel to sort by type (music,movie),Genre and sub-media type. You will also have the option to display each listing as either Filname or Title. Between all of these options, its pretty easy to manage large collections
-
thanks guys I will definitely like feedback and input. I will post back when things are integrated enough for testing purposes while I wait to see if anyone is interested in doing the graphic work.
Jimmy - It just uses database information, so you will be abel to sort by type (music,movie),Genre and sub-media type. You will also have the option to display each listing as either Filname or Title. Between all of these options, its pretty easy to manage large collections
What do you need? Give me some specs.
-
gbutter - if you are interested PM me your email and I will send the source graphic files. Just use them as templates to make it look nicer (maybe some 3D highlighting effect etc)
-
gbutter - if you are interested PM me your email and I will send the source graphic files. Just use them as templates to make it look nicer (maybe some 3D highlighting effect etc)
PM sent
-
Thank you, I'll check it out.
I'm hoping to have the coding portion wrapped up within the next couple of days at which time I'll be ready some templates to work off of.
thanks again
-
I've committed changes to svn. Please give it a thorough workout and give some feedback. For information on how to get the changes, see here
http://forum.linuxmce.org/index.php?topic=5666.0 (http://forum.linuxmce.org/index.php?topic=5666.0)
Changelog
-Added Vertical layout option (still defaults to horizontal layout) This can be toggled even in the middle of editing a playlist.
-Graphics added to make a more intuitive UI (vertical layout only) (placeholder graphics at this time)
-Reworked Horizontal layout to allow more room for long filenames
-Removed ability to filter by sub-media type, as it isn't very useful and just not worth it for how much it complicated the SQL queries
-Choosing media type "All" no longer shows unsupported media types (i.e. .jpg and other types not supported by the playlist system). This shortened my list from over 4000 to under 1000! Bottom line is that you are only presented with a list of media that will work if added to the playlist.
-Changed "Order By" filename/title to "Display As" filename/title. This is much more user-friendly, as there may be some files where you are more familiar with the title, and other files you are more familiar with the filename.
-Added feature to gracefully handle files that have no Title attribute set if the user sets to display as title.
-Fixed filter by genre bug
-Fixed bug where a file removed from the playlist didn't re-appear in the media files list
-Changes are now automatically saved if you change pages while editing a playlist
-Fixed a bunch of improper SQL join operations
-added option for user to select records per page (default is still 1000)
-Fixed layout bug where a large number of pages would break up the screen layout
-Moved general properties such as Playlist Name and Image to the bottom of the page as they are more of a secondary function of the playlist editor.
-Fixed bug that would delete all entries of the playlist if an option on the left main menu pane was clicked while editing a playlist
-Changed how Filenames and Titles are displayed, taking up much less space and being more intuitive
-fixed bug that would reset the page to 1 after saving changes
-User privacy is now respected. Only media files that are public or owned by the user currently logged into the web admin are presented to the user for inclusion into their playlist.
-Playlist changes now auto-save when changing media file pages
-various other sorting/filtering bugs fixed.
-
:D
This works great. It is especially friendly to the 640x480 resolution of my 42" TV (old projection type).
Great Work!!!
Regards,
Seth
-
The playlist editor is working well for me.
I have about 4,500 songs and this makes it working with a playlist do-able as opposed to the on-screen version.
Some may not know that what you're working on is available in the Pluto Admin Screen, Files & Media > Playlists. I never saw or used the original one but I can say what you've created is easy to work with.
I just had a MD in my office playing a playlist I created a few weeks ago and it just stopped (which has been an ongoing problem for me) but at least this time I was able to read in the top left corner that the next tune in the list was unavailable/didn't exist!
Which brings me to...
Did I not read in your descriptions that it validates files? (to ensure they exist?)
And with my 4500 songs, how would I search for the song (I know which one it is) in the playlist so I can remove it?
-
Freymann - thanks for the report.
The playlist editor doesn't check for the existance of a file, it only relies on the database saying that there is a file. Maybe I will look into a way to actually verify that the file is there as the database says it is. The only problem is that to check it for each file while loading the list seems like a bit of overkill. There are other utilities to make sure your database and filesystem are in sync, so we should probably rely on those. Still, i'm going to try to reproduce it to make sure it isn't something else.
Here is how you can see if your have files in your database that aren't on the disk...
In the web admin, go to Files & Media -> Media Files Sync
use the left pane to browse to a music folder (home/public/data/audio/your_disk_drive
When you navigate to a device containing music, the music will be listed on the right hand side. If you scroll to the bottom of that page, you will see a checkbox "Show files who are missing from disk" - check that box.
Change files per page to a high number, or all..
then just scroll through all of them looking for the little disk platter icon indicating that the file exists only in the database. You can manually get rid of the entries if you want..
Of course, the easier way is to just hit the resyncronize button at the top of the page. Beware, however, that if you hit Resyncronize when you are not at an end level disk device containing media files, you can have unexpected results (which is why i prefer to do the cleanup manually)
-
The playlist editor doesn't check for the existance of a file, it only relies on the database saying that there is a file. Maybe I will look into a way to actually verify that the file is there as the database says it is. The only problem is that to check it for each file while loading the list seems like a bit of overkill. There are other utilities to make sure your database and filesystem are in sync, so we should probably rely on those. Still, i'm going to try to reproduce it to make sure it isn't something else.
Yes, I think in that case a separate program that can be run to clean things up would be a better solution.
Thanks to your instructions, here's what I found is causing my grief with the playlist!
When I originally 'tested' things out, I copied some music onto the main drive into the /home/public/data/audio/ directory.
When I was ready to move the test core out into the main area, back in mid-June, I then installed my second 'media drive' which contains my entire collection.
What I've found is the leftovers.... I likely just manually deleted the batch of tunes I was testing with from the drive, leaving their entries in the database but not on disk.
So I selected one "band" and said delete.
It took a long time... and it seems to have deleted everything?
As now, when I navigate into the media drive, I see only the symbol indicating the things exist on disk only.
From the MD in my office, I go to Media > Audio and everything is empty.
I guess it will rebuild my audio inventory??
That is weird. I had checked off one band, clicked delete from database, and it deletes my entire audio collection.
-
So stupid me, I check out the main drive in the /home/public/data/video directory and see three directories I deleted, so I click the delete from database button and it wipes out ALL of my video content from the db.
The core is busy rebuilding inventory, but this is definitely a BUG.
The buttons beside the item aren't passing along the ID I suppose.
This brings up another thing I was wondering about...
If we have "media" that can be online/offline.... If I click on Media > Audio > Other > Play All, shouldn't it only include audio that is marked "online"? or how is that handled? (same would be true for video and pictures).
I think this explains why my music keeps cutting out at random intervals. The "Play All" thing includes off-line content.
Interesting stuff!
-
Perhaps we need to start a new thread, but after the system deleted all of my music and videos, there's another issue that has appeared.
In my video collection (which is rather large too) it rebuilt the inventory, but the "media sub-type" field didn't come back.
That meant I had to go over my entire video collection, one by one, and adjust the media subtype to "Music Video" or "Movie" and in a few cases, add back the Genre (I only use that one sparingly).
That took 30 minutes.. (but mind you, I didn't bother with the hundreds of short music videos) which really, isn't too bad, but I would generally say I'm not doing that again and leave it. The only reason I walked through all the files is because the "wife" still isn't convinced LMCE is great, and now that I've shown her the attribute controls, to have them suddenly missing isn't going to help me.
LMCE has been around long enough that surely somebody else has noticed these bugs?
-
that is why I use Media Files Sync manually and carefully (i'm sorry if I didn't convey that enough). It does bad things if the correct directory isn't selected.
So far, the playlist editor seems bug free. I'll wait a few days, and if I don't hear any different, I will close out the mantis tickets.
-
Ok, the final graphics are in for the vertical playlist editor layout (thankyou gbutters). It has been committed to SVN.
If you want to try it out, just svn update, and copy the charon-merge/web/pluto-admin/operations/mediaBrowser/images directory over as described here http://forum.linuxmce.org/index.php?topic=5666.0 (http://forum.linuxmce.org/index.php?topic=5666.0)
-
Jon - one piece of feedback, I believe that the query you use to retrieve potential media for the list to add from needs to filter out media entries that are marked as not-on-disk or that the device is offline.
I did a fair bit of editing to get rid of ' characters by renaming. Of course updatae media sees these as new files and the old was simply as missing from disk (until I get around to cleaning it all up) but the playlist editor shows them all, so there are many duplicates (many of which will cause the media plugin to stop playing the play list because they no longer exist)
-
I get some time off of work in a couple of day, so this is one thing I will look into.. However, I don't think whether or not the media is available or on a mounted disk or not is stored as a flag in the database - and checking each db entry against actual files would take a lot of un-needed overhead. Simply put, making sure the files exist is handled by other parts of LMCE, and may be over-redundant to include such functionalitly in playlist building.
However, if there is some sort of "exists on disk" flag in the database, it may be feasible. Also, in my optinion, it would be best handled at the plugin level to fail safely if a file does not exist. This way, you can still add a file to your playlist that exists on a network share for example. When playing back, if that share is not available, then it should fail silently at the plugin level, and continue to the next playlist entry. This to me seems more flexable and a more proper way to do this.
Any thoughts on this?
-
hmmmm I have a feeling there is that flag as I saw something recently that suggested it was being set. Also, in one of the SQL queries I was reading in a php (I think) somewhere it seemed to be explicitly excluding those files based on that attribute.... will take a look and see if I can find it again....
Edit:
This snip from mainMediaFilesSync.php might help, note the bold bit..
function dbonlyFilesList($path,$physicalFiles,$mediadbADO){
// include language files
include(APPROOT.'/languages/'.$GLOBALS['lang'].'/common.lang.php');
include(APPROOT.'/languages/'.$GLOBALS['lang'].'/mainMediaFilesSync.lang.php');
$dpage=((int)@$_REQUEST['dpage']>0)?(int)$_REQUEST['dpage']:1;
$queryDBFiles='
SELECT DISTINCT File.*,count(FK_Picture) AS picsNo
FROM File
LEFT JOIN Picture_File ON FK_File=PK_File
WHERE (Path="'.addslashes($path).'" OR Path="'.addslashes($path).'/'.'") AND Filename NOT IN ("'.join('","',array_map('addslashes',$physicalFiles)).'") AND Missing=1
GROUP BY PK_File';
$rs=$mediadbADO->_Execute($queryDBFiles);
$dbFiles=array();
$dbPKFiles=array();
while($row=$rs->FetchRow()){
$dbFiles[]=$row['Filename'];
$dbPKFiles[]=$row['PK_File'];
$dbPicsNoFiles[]=$row['picsNo'];
-
In the 'file' table in pluto_media, there is a column called 'missing'. Maybe thats what you gents mean?
-
In the 'file' table in pluto_media, there is a column called 'missing'. Maybe thats what you gents mean?
Thanks golgoj4 - that's where I was headed, just found a snip above using exactly that. The UpdateMedia log file indicates it is "marking" files as missing in some circumstances and I'm pretty sure it uses that. I think the Orbiter uses it to eliminate offline files. But as I say, I may be confused - not sure that missing files from online disks are the same as files unavailable because the entire disk is offline....