LinuxMCE Forums

General => Developers => Topic started by: stefan on July 17, 2013, 03:19:23 pm

Title: ZWave stack fixes
Post by: stefan on July 17, 2013, 03:19:23 pm
Hi,

Where should suggested fixes be sent? I made the following updates:
- fixed logic to not overwrite the setpoint in the State string with basic reports
- added functionality for more setpoint types (e.g. economy heat, economy cool)
- added polling of thermostats for the setpoint and mode
- added support for floating point setpoints reported by thermostats
- made the code a bit more legible by defining constants for the setpoint types

I can send the delta of the code to whoever needs it.

Thanks,
Stefan
Title: Re: ZWave stack fixes
Post by: coley on July 17, 2013, 05:11:16 pm
Sambuca or Hari are probably best to check this with.
Did you make these changes on the current Zwave stack? or the newer one based on OZW?

-Coley.
Title: Re: ZWave stack fixes
Post by: stefan on July 17, 2013, 06:15:21 pm
The changes are on the current Zwave stack.

Everything was tested using a Honeywell YTH8320ZW1007 thermostat.

Thanks,
Stefan
Title: Re: ZWave stack fixes
Post by: tschak909 on July 17, 2013, 06:28:28 pm
Thanks! Feel free to make a ticket in http://svn.linuxmce.org/ and submit an svn diff as an attachment!

-Thom
Title: Re: ZWave stack fixes
Post by: stefan on July 17, 2013, 06:39:47 pm
Thanks. I created Ticket #1844 and attached the svn diff.

Regards,
Stefan
Title: Re: ZWave stack fixes
Post by: tschak909 on July 17, 2013, 06:42:49 pm
Cool, according to Hari, we've moved over to using the zwave-OZW stack, based on the OpenZWave 1.0 library, have you looked @ it yet?

-Thom
Title: Re: ZWave stack fixes
Post by: stefan on July 17, 2013, 06:55:38 pm
No I haven't in the context of LinuxMCE. Only browsed the code a bit in the Google repository for the purpose of gaining a better understanding of ZWave. It does appear to have a more complete implementation, but I'm not familiar with how it get integrated into LinuxMCE.

Regards,
Stefan
Title: Re: ZWave stack fixes
Post by: tschak909 on July 17, 2013, 06:58:44 pm
The relevant code is in trunk/src/ZWave-OZW.

-Thom
Title: Re: ZWave stack fixes
Post by: Hackit2me on July 29, 2013, 06:45:03 pm
I recently submitted a seperate ticket which covers ~some~ of the same issues, before I noticed this other ticket was already submitted.

Mine: Ticket 1853

I'm thinking a merge of these two might be in order.   But we may have to hammer out some of the differences first....

Chris
Title: Re: ZWave stack fixes
Post by: Hackit2me on August 13, 2013, 11:34:21 pm
Completed Partial merge.

See Trac Ticket# 1853
Title: Re: ZWave stack fixes
Post by: tschak909 on August 14, 2013, 03:47:11 am
FANTASTIC! Thanks! :)

-Thom
Title: Re: ZWave stack fixes
Post by: Hackit2me on August 21, 2013, 04:30:25 am
Added another version of the patch to the Trac ticket, containing feedback and bug fixes from Stefan.
Will wait for a review and more comments from him.