LinuxMCE Forums

General => Developers => Topic started by: KingCrab on May 27, 2010, 01:48:48 pm

Title: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on May 27, 2010, 01:48:48 pm
Hi everybody,

it seems as we have some problems reading id3 files with special characters. At the moment I try to change the underlaying tagging library to fix this, but I need some help testing the stuff. At this point I haven't added any new features, so testing would be limited to everything that is possible with the original version (like scanning, removing/editing of tags, etc.).

As this is an early version, you maybe shouldn't use it on your productive systems.

UpdateMedia.rar (784 KB) (http://i.imagehost.org/download/0596/UpdateMedia)



An actual patch can be found here: http://svn.linuxmce.org/trac.cgi/ticket/698 (http://svn.linuxmce.org/trac.cgi/ticket/698)



Thanks for your help,
KingCrab
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: tschak909 on May 27, 2010, 02:28:23 pm
Hello, can you provide an svn diff to attach to a trac ticket, so we can track this?

-Thom
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: murcel on May 28, 2010, 11:54:34 pm
so how can i help?

murcel


Hi everybody,

it seems as we have some problems reading id3 files with special characters. At the moment I try to change the underlaying tagging library to fix this, but I need some help testing the stuff. At this point I haven't added any new features, so testing would be limited to everything that is possible with the original version (like scanning, removing/editing of tags, etc.).

As this is an early version, you maybe shouldn't use it on your productive systems.

UpdateMedia.rar (784 KB) (http://i.imagehost.org/download/0596/UpdateMedia)

Thanks for your help,
KingCrab
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on May 30, 2010, 08:25:04 am
@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.

Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: murcel on May 30, 2010, 03:01:00 pm
First tests are good.
German umlauts are imported correctly.

@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.


Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: tschak909 on May 30, 2010, 05:03:34 pm
Dude, that's not the point, maybe we'd like to _HELP_.

I do not want "go off in a cave and do all the work yourself" to be the norm.

hmm.

-Thom

@Thom: I will, but give me some time to get a working version at first. I don't like the idea of publishing crap that is not usable in any way.

@Murcel Just download the file and play a little bit with it. If available scan some files with and without special chars, edit Attributes, remove them,  play the files. What you would do in regular use.


Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on June 05, 2010, 08:32:27 am
New Version should fix some problems and add basic ape support.

UpdateMedia.zip (1.5 MB) (http://i.imagehost.org/download/0844/UpdateMedia)
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on June 15, 2010, 07:09:44 pm
With a little luck everything is still working  ;) + ogg and flac fixed

UpdateMedia.gz (1.5 MB) (http://i.imagehost.org/download/0438/UpdateMedia)
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: apagg on June 15, 2010, 10:25:13 pm
Great work

I have utf support for mp3 flac and ogg, but only picture for mp3.

Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: apagg on June 16, 2010, 09:45:40 pm
Import of .mkv and .avi are broken in the last UpdateMedia :(
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on June 17, 2010, 09:59:41 pm
That's strange. Didn't know I touched the video part. Could you descripe what happens? Does it definitely happen with the last version for the first time?
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: apagg on June 18, 2010, 08:35:09 pm
I have done more testing it looks like it happens with earlier versions as well. The same result happens if the .mp3 file dont contain any tags.

Logfile from original UpadateMedia: http://pastebin.com/Liy8JTqh

Your latest: http://pastebin.com/MCLCfvfe
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: tschak909 on June 18, 2010, 09:16:57 pm
we REALLY need someone to OWN UpdateMedia.

-Thom
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on June 20, 2010, 07:46:34 pm
Next one. Video and empty mp3 files shouldn't crash any more.

UpdateMedia.gz (1.5 MB) (http://i.imagehost.org/download/0504/UpdateMedia)
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: apagg on June 20, 2010, 09:50:54 pm
My testing so far

.mp3 (id3 v2.3):Works for special characters and pictures
.mp3 (id3 v2.4):Works for special characters and pictures
.ogg: works for special characters
.flac: works for special characters
.mkv: works for special characters in filename
.avi: works for special characters in filename

great work :)
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: tschak909 on June 20, 2010, 09:53:54 pm
We need to be sure that any tags we write in the web admin, get written to the files, especially stuff that does not fit in the schema, such as media type/subtype. This is critical.

The format of these GEOB tags is data passed in from SerializeClass

-Thom
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: murcel on June 23, 2010, 07:52:37 pm
Next one. Video and empty mp3 files shouldn't crash any more.

UpdateMedia.gz (1.5 MB) (http://i.imagehost.org/download/0504/UpdateMedia)

does not go through for all files.....UpdateMedia.log doesn't contain any entries.

Only first file is processed

sudo -u root /usr/pluto/bin/UpdateMedia -d \"/home/public/data/audio/ST31000525SV (sdd1) on dcerout [469]/a-z/Ina Müller\"
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: KingCrab on June 27, 2010, 08:17:49 pm
I want to say thanks to all who are helping me testing this stuff!

There was a bug with reading of user defined urls. Should be fixed and in addition flac pictures should work now, too.

UpdateMedia.gz (1.5 MB) (http://h.imagehost.org/download/0385/UpdateMedia)

Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: murcel on June 28, 2010, 09:04:18 pm
I want to say thanks to all who are helping me testing this stuff!

There was a bug with reading of user defined urls. Should be fixed and in addition flac pictures should work now, too.

UpdateMedia.gz (1.5 MB) (http://h.imagehost.org/download/0385/UpdateMedia)


this file is working now, but please check your pm.
Title: Re: Tester for updateMedia id3 unicode fix needed
Post by: cfernandes on July 17, 2010, 09:43:07 pm
hi ,

i have some errors  like this

5      07/17/10 16:39:55.564        # PlutoMediaFile STARTED: dir /home/public/data/audio file Alexandre Pires - Eva, Meu Amor.mp3 <0xb636d6c0>
10      07/17/10 16:39:55.564        # ID3FileHandler::LoadAttributes: loading 0 attributes in the attribute file /home/public/data/audio/Alexandre Pires - Eva, Meu Amor.mp3 <0xb636d6c0>
10      07/17/10 16:39:55.598        # LoadPlutoAttributes: pluto attributes loaded (from id3 file - general object tag) 0 <0xb636d6c0>
/usr/pluto/bin/UpdateMedia: symbol lookup error: /usr/pluto/bin/UpdateMedia: undefined symbol: _ZNK6TagLib5ID3v218PopularimeterFrame5emailEv